Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Skip a flaky webview_flutter integration test and extend firebase testlab timeout #4195

Merged
merged 1 commit into from Jul 27, 2021

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jul 26, 2021

CI tends to either fail due to a flaky test in webview_flutter or the test times out.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jul 26, 2021
@github-actions github-actions bot added the p: webview_flutter Edits files for a webview_flutter plugin label Jul 26, 2021
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: webview_flutter Edits files for a webview_flutter plugin
Projects
None yet
2 participants