This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Remove pubspec.yaml examples from READMEs #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonstrations of how to add a plugin dependency in pubspec.yaml inevitably become outdated, causing more confusion than the solve. pub.dev has an installation tab which shows the same example but using a dynamic version, so these instructions are almost never necessary; where specifically referencing installation is useful, link to that tab instead of an inline, hard-coded example. Many of these examples were in implementation packages that were not endorsed, and had never been updated to indicate that they are now endorsed, so this PR also corrects those READMEs to indicate that they are in fact endorsed. Fixes flutter/flutter#87056
stuartmorgan
commented
Jul 27, 2021
| @@ -1,195 +1,3 @@ | |||
| # e2e (deprecated) | |||
|
|
|||
| ## DEPRECATED | |||
|
|
|||
There was a problem hiding this comment.
This package is several deprecations old, and only this README exists in the tree (in case people have links to the package), so rather than do a targeted update I just nuked everything but the pointer.
ditman
approved these changes
Jul 27, 2021
| @@ -1,195 +1,3 @@ | |||
| # e2e (deprecated) | |||
|
|
|||
| ## DEPRECATED | |||
|
|
|||
stuartmorgan
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrations of how to add a plugin dependency in pubspec.yaml
inevitably become outdated, causing more confusion than they solve.
pub.dev has an installation tab which shows the same example but using a
dynamic version, so these instructions are almost never necessary; where
specifically referencing installation is useful, link to that tab
instead of an inline, hard-coded example.
Many of these examples were in implementation packages that were not
endorsed, and had never been updated to indicate that they are now
endorsed, so this PR also corrects those READMEs to indicate that they
are in fact endorsed.
Fixes flutter/flutter#87056
Pre-launch Checklist
dart format.)[shared_preferences]///).