Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Mark iOS arm64 simulators as unsupported #4208

Merged
merged 3 commits into from Aug 3, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jul 30, 2021

Before flutter/flutter#87244, any app using the google_sign_in plugin would not build on an M1 Mac.

Replace deprecated 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' with 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'arm64'. Once GoogleSignIn 6.0 is adopted, this build setting can be removed.

Fixes flutter/flutter#87243
See also #4209

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman
Copy link
Member Author

jmagman commented Jul 30, 2021

Test failure to be fixed in flutter/flutter: flutter/flutter#87362

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/google_sign_in/google_sign_in/CHANGELOG.md Outdated Show resolved Hide resolved
@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 2, 2021
@fluttergithubbot fluttergithubbot merged commit c59b32c into flutter:master Aug 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
@jmagman jmagman deleted the gsi-excluded branch August 3, 2021 20:20
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: google_sign_in platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
3 participants