Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci.yaml] Auto-generate LUCI configs #4223

Merged
merged 5 commits into from Aug 11, 2021
Merged

[ci.yaml] Auto-generate LUCI configs #4223

merged 5 commits into from Aug 11, 2021

Conversation

CaseyHillers
Copy link

@CaseyHillers CaseyHillers commented Aug 9, 2021 •
edited

Add the information necessary to no longer require the starlark code in flutter/infra

flutter/flutter#85803

See https://flutter-review.googlesource.com/c/infra/+/16742 for the auto-generated diff

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Aug 9, 2021
CaseyHillers
CaseyHillers commented Aug 9, 2021
View reviewed changes
.ci.yaml
targets:
- name: Windows Plugins
builder: Windows Plugins
postsubmit: false
recipe: plugins/plugins
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consolidated this with the postsubmit "Windows Plugins master channel" which was equivalent

stuartmorgan
stuartmorgan reviewed Aug 9, 2021
View reviewed changes
.ci.yaml Outdated
]
device_type: none
os: Windows

targets:
- name: Windows Plugins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is master, can we name it "Windows Plugins master channel" for clarity?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I sent https://flutter-review.googlesource.com/c/infra/+/16745 as we need to add a try builder before we can rename it here

.ci.yaml
targets:
- name: Windows Plugins
builder: Windows Plugins
postsubmit: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own understanding: what is controlling presubmit vs postsubmit in these configs? Or is "both" the default?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True is the default, so both run by default. The config links to https://cs.opensource.google/flutter/cocoon/+/master:CI_YAML.md which is the config documentation.

stuartmorgan
stuartmorgan reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment. Beyond that, @godofredoc should definitely review since I have no experience with these files so far, and several important-looking properties aren't documented, so my ability to provide a meaningful review is limited.

.ci.yaml Outdated
scheduler: luci

- name: Windows Plugins stable channel
recipe: plugins/plugins
presubmit: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this false? We should be running the windows tests on both presubmit and postsubmit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to match the LUCI config (thanks for validating this makes sense!). I sent https://flutter-review.googlesource.com/c/infra/+/16782 to add a presubmit builder.

@CaseyHillers CaseyHillers added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 11, 2021
@fluttergithubbot fluttergithubbot merged commit b9ac641 into flutter:master Aug 11, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
@engine-flutter-autoroll
b9ac641 [ci.yaml] Auto-generate LUCI configs (flutter/plugins#4223)
08f95f1
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@fotiDim
[ci.yaml] Auto-generate LUCI configs (flutter#4223)
e94f990
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@amantoux
[ci.yaml] Auto-generate LUCI configs (flutter#4223)
923f552
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan left review comments

@godofredoc godofredoc godofredoc approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@CaseyHillers @stuartmorgan @godofredoc @fluttergithubbot