Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Don't request full-screen mode in unlockCaptureOrientation #4226

Merged
merged 1 commit into from Aug 12, 2021
Merged

[camera_web] Don't request full-screen mode in unlockCaptureOrientation #4226

merged 1 commit into from Aug 12, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Aug 11, 2021

Removes requesting full-screen mode in unlockCaptureOrientation as suggested in #4219 (comment).

Part of flutter/flutter#45297.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Aug 11, 2021
@bselwe bselwe mentioned this pull request Aug 11, 2021
Open
@bselwe
Copy link
Contributor Author

bselwe commented Aug 11, 2021

@ditman @felangel

@bselwe bselwe mentioned this pull request Aug 11, 2021
Merged
11 tasks
ditman
ditman approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we don't have to roll-back this one :P

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 12, 2021
@fluttergithubbot fluttergithubbot merged commit d6ba532 into flutter:master Aug 12, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
@engine-flutter-autoroll
d6ba532 fix: don't request full-screen mode in unlockCaptureOrientati…
ff0170c 
…on (flutter/plugins#4226)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@bselwe @fotiDim
fix: don't request full-screen mode in unlockCaptureOrientation (flut…
5f665f3 
…ter#4226)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bselwe @amantoux
fix: don't request full-screen mode in unlockCaptureOrientation (flut…
8089d30 
…ter#4226)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@bselwe @ditman @fluttergithubbot