[camera] Replace device info with new device_info_plus

[mhadaily]

this plugin has been replaced by the Flutter Community Plus Plugins version, device_info_plus. No further updates are planned to this plugin, and we encourage all users to migrate to the Plus version.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[stuartmorgan]

• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.

Please don't just check checkboxes indiscriminately; this PR doesn't currently do either of this things, and needs to.

[mhadaily]

I'm sorry @stuartmorgan I just didn't know whether I should really add anything to pubspec or changelog as this PR is only changing the README file.

Do you think I should pump the version and add a changelog because of this change? if so, I'll do it right away.

[stuartmorgan]

This is discussed in the first link on that line.

Is the issue that the discussion it links to isn't clear about this case, or that you didn't realize that link would answer this question? I'd like to fix the template and/or wiki to avoid this in the future.

[mhadaily]

I trusted myself more than I must due to my previous contribution. @stuartmorgan that is obviously my fault where I didn't read carefully.

here is the text if someone sees this PR later, just in case.

Do I need to update the version if I'm just changing the README? Yes. Most people read the README on pub.dev, not GitHub, so a README change is not very useful until it's published.

Fixed now.

[stuartmorgan]

@stuartmorgan that is obviously my fault where I didn't read carefully.

You're not the first person to have missed it, which suggests that the documentation is at fault. I'd like to figure out whether people are following the link but missing the FAQ, or if they aren't following the link at all, so that I can figure out where to make adjustments.

[stuartmorgan]

Nit: 0.9.1+1 per the discussion of pre-1.0 versions here.

[mhadaily]

Well,
I actually opened that link and just read the first paragraph. As soon as I saw the FAQ, I ignored the questions and skipped it until the next section. Since I contributed before, I didn't think even for a second that might help, that's probably my fault.

I am not sure if this is a fault in the documentation. It's probably me that I should have paid attention to the whole text.

[stuartmorgan]

LGTM, thanks!