Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Update ultra high resolution to 4096x2160 #4279

Merged
merged 2 commits into from Aug 27, 2021
Merged

[camera_web] Update ultra high resolution to 4096x2160 #4279

merged 2 commits into from Aug 27, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Aug 27, 2021

Updates ultra high resolution from 3840x2160 to 4096x2160 to the web camera platform. Fixes an issue when requesting the maximum camera resolution resulted in a 640x480 camera, rather than 1280x720.

Part of flutter/flutter#45297.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe
Copy link
Contributor Author

bselwe commented Aug 27, 2021

@ditman

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this one, but I have a feeling that these presets are going to be quickly surpassed by the capabilities of the hardware :/

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 27, 2021
@ditman ditman merged commit 863d088 into flutter:master Aug 27, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
* feat: update ultra high resolution to 4096x2160

* test: update max and ultra high resolution tests
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
* feat: update ultra high resolution to 4096x2160

* test: update max and ultra high resolution tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
2 participants