[google_maps_flutter] Bump minimum Flutter version and iOS deployment target #4333
Conversation
@@ -2,11 +2,11 @@ name: google_maps_flutter | |||
description: A Flutter plugin for integrating Google Maps in iOS and Android applications. | |||
repository: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter/google_maps_flutter | |||
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 | |||
version: 2.0.8 | |||
version: 2.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's a public API change here so a minor version bump should be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring a new Flutter stable isn't cause enough for a minor bump? @stuartmorgan what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think what we're doing really fits into the semver scheme, so I think it doesn't especially matter. Since the resolver will prevent someone for whom this won't work from ever getting it in the first place, and for anyone else it's basically a bugfix (it won't get modified on the fly, and for some packages will stop having so many deprecation warnings) I think a bugfix bump is fine.
But I'm also fine with saying "it's not exactly a bugfix either so lets call it a minor bump". 🤷🏻
(If I'm the tiebreaker here, I think I'd lean slightly toward bugfix bump rather than minor bump).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Flutter apps run on 2.4.0-0.0.pre and later will be upgraded to a minimum of iOS 9.0. Now that Flutter 2.5 has hit stable and iOS 8 support has been dropped, change the plugin minimum iOS version to
9.0
.Bump the Flutter and dart version constraints to 2.5 and 2.14 respectively to enforce that the iOS 9.0 migration has happened on the app side, because an older 8.0 app won't build with a 9.0 plugin. I believe the last time this was done was a few months ago for null safety adoption #3324 (there's recent precedent).
Users on Flutter versions lower than the current stable 2.5 will not be able to upgrade this plugin past this version.
google_maps_flutter part of flutter/flutter#84198
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).