This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_wkwebview] Load example App's navigation controls immediately. #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
p: webview_flutter
BeMacized
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
mvanbeusekom
force-pushed
the
issue/90597_wkwebview
branch
from
b5abcb6
to
518c285
Compare
mvanbeusekom
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
Make sure the navigation controls in the example App are loaded immediately but only enable when the WebViewController is available. This is the same behavior as in the example App from the main webview_flutter package.
mvanbeusekom
force-pushed
the
issue/90597_wkwebview
branch
from
518c285
to
be5c202
Compare
mvanbeusekom
added
the
waiting for tree to go green
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Sep 27, 2021
* master: Load navigation controls immediately. (flutter#4378) [ci] Temporary run publish task on Flutter stable channel. (flutter#4388) [in_app_purchase] Bump dependencies on json_serializable, build_runner (flutter#4386) # Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 28, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 28, 2021
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the navigation controls in the example App are loaded immediately, but only enable when the WebViewController is available. This is the same behaviour as in the example App from the main webview_flutter package.
Related to issue flutter/flutter#90597
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.