Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter_web] Add Marker drag events #4385

Merged

Conversation

JamesMcIntosh
Copy link
Contributor

Add events to track start of drag and position during drag for Google Maps Flutter Web

Issue: flutter/flutter#26117
Platform changes: #2653
Flutter app: #2838

Pre-launch Checklist

  • [/] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [/] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [/] I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [/] I signed the [CLA].
  • [/] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [/] I listed at least one issue that this PR fixes in the description above.
  • [/] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • [/] I updated CHANGELOG.md to add a description of the change.
  • [/] I updated/added relevant documentation (doc comments with ///).
  • [/] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • [/] All existing and new tests are passing.

@JamesMcIntosh
Copy link
Contributor Author

@stuartmorgan looks like the might still be a problem with the publishable check for google maps flutter. This is what the error message is saying when there is both a README.md and CHANGELOG.md file in that package.

�[31mERROR: Package validation found the following errors:
* The pubspec is hidden, probably by .gitignore or pubignore.
* You must have a LICENSE file in the root directory.
  An open-source license helps ensure people can legally use your code.
Package validation found the following potential issues:
�[0m
�[31mERROR: * Please add a README.md file that describes your package.
* Please add a`CHANGELOG.md` to your package. See https://dart.dev/tools/pub/publishing#important-files.
Sorry, your package is missing some requirements and can't be published yet.
For more information, see: https://dart.dev/tools/pub/cmd/pub-lish.
�[0m
�[31mERROR: pub finished with exit code 65
�[0m
Unable to publish google_maps_flutter_web

@stuartmorgan
Copy link
Contributor

See #4388

@ditman
Copy link
Member

ditman commented Sep 29, 2021

This branch needs to be updated with master for it to pass the publishable check. @JamesMcIntosh if you give us permissions in the PR (there's a checkbox near the bottom when creating a PR that says something similar to: "Allow edits from maintainers"), I can do some of these chores for you while reviewing the code.

@ditman ditman self-assigned this Sep 29, 2021
@JamesMcIntosh
Copy link
Contributor Author

JamesMcIntosh commented Sep 29, 2021

Both branches already had the "allow maintainers" permission checked, just did a rebase and push

@JamesMcIntosh JamesMcIntosh force-pushed the google-maps-marker-drag-events-web branch from 15a7144 to 30283ce Compare September 29, 2021 20:11
@JamesMcIntosh
Copy link
Contributor Author

@stuartmorgan Now the submit-queue is failing and the "details" link now take you to a page full of JSON rather than the summary.
https://api.github.com/repos/flutter/plugins/check-suites/3911833499/check-runs

This is the format of the other links (not pointing to the api subdomain).
https://github.com/flutter/plugins/pull/4385/checks?check_run_id=3748907644

@stuartmorgan
Copy link
Contributor

@stuartmorgan Now the submit-queue is failing

That's a live check indicating that the tree is currently closed so nothing can land. You don't need to do anything.

and the "details" link now take you to a page full of JSON rather than the summary.

We don't control the format of the check, it's an external app

@ditman ditman changed the title [google_maps_flutter] Google maps marker drag events web [google_maps_flutter_web] Add Marker drag events Sep 30, 2021
@ditman ditman self-requested a review September 30, 2021 01:23
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for including tests, and pushing the updated mocks!

@ditman ditman merged commit 90b2844 into flutter:master Sep 30, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 30, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull request Sep 30, 2021
* master:
  [google_maps_flutter] Add Marker drag events (flutter#2838)
  [flutter_plugin_tools] Validate pubspec description (flutter#4396)
  Add file_selector to the repo list (flutter#4395)
  [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)
  [google_maps_flutter_web] Add Marker drag events (flutter#4385)
  [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394)
  Handle `PurchaseStatus.restored` correctly in example. (flutter#4393)
  Handle restored purchases in iOS example app (flutter#4392)
  [file_selector] Remove custom analysis options (flutter#4382)
  [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373)
  Fixed _CastError when running example App (flutter#4390)
  [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370)
  Load navigation controls immediately. (flutter#4377)
  [camera] Fix IllegalStateException being thrown in Android implementation when switching activities. (flutter#4319)

# Conflicts:
#	packages/webview_flutter/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/webview_flutter_android/CHANGELOG.md
mgonzalezc pushed a commit to mgonzalezc/plugins that referenced this pull request Oct 12, 2021
* master: (1126 commits)
  [webview_flutter] Adjust test URLs again (flutter#4407)
  [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179)
  [camera] Add filter for unsupported cameras on Android (flutter#4418)
  [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401)
  [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404)
  [ci] Remove obsolete Dockerfile (flutter#4405)
  Fix order-dependant platform interface tests (flutter#4406)
  [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374)
  [google_maps_flutter] Add Marker drag events (flutter#2838)
  [flutter_plugin_tools] Validate pubspec description (flutter#4396)
  Add file_selector to the repo list (flutter#4395)
  [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)
  [google_maps_flutter_web] Add Marker drag events (flutter#4385)
  [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394)
  Handle `PurchaseStatus.restored` correctly in example. (flutter#4393)
  Handle restored purchases in iOS example app (flutter#4392)
  [file_selector] Remove custom analysis options (flutter#4382)
  [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373)
  Fixed _CastError when running example App (flutter#4390)
  [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370)
  ...

# Conflicts:
#	packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants