[image_picker][android] suppress unchecked warning

[lukaskurz]

Casting a Object to an ArrayList from a map causes an unchecked cast warning, which shows up during builds of the image_picker plugin. Looking at the code, we can verify that the only times the value belonging to cache.MAP_KEY_PATH_LIST is set, it is an ArrayList.

Map<String, Object> resultMap = new HashMap<>();
    ArrayList<String> pathList = new ArrayList<>();
    boolean hasData = false;

    if (prefs.contains(FLUTTER_IMAGE_PICKER_IMAGE_PATH_KEY)) {
      final Set<String> imagePathList =
          prefs.getStringSet(FLUTTER_IMAGE_PICKER_IMAGE_PATH_KEY, null);
      if (imagePathList != null) {
        pathList.addAll(imagePathList);
        resultMap.put(MAP_KEY_PATH_LIST, pathList); // here
        hasData = true;
      }
    }

and

ArrayList<String> pathList = (ArrayList<String>) resultMap.get(cache.MAP_KEY_PATH_LIST);
    ArrayList<String> newPathList = new ArrayList<>();
    if (pathList != null) {
      for (String path : pathList) {
        Double maxWidth = (Double) resultMap.get(cache.MAP_KEY_MAX_WIDTH);
        Double maxHeight = (Double) resultMap.get(cache.MAP_KEY_MAX_HEIGHT);
        int imageQuality =
            resultMap.get(cache.MAP_KEY_IMAGE_QUALITY) == null
                ? 100
                : (int) resultMap.get(cache.MAP_KEY_IMAGE_QUALITY);

        newPathList.add(imageResizer.resizeImageIfNeeded(path, maxWidth, maxHeight, imageQuality));
      }
      resultMap.put(cache.MAP_KEY_PATH_LIST, newPathList); // and here
      resultMap.put(cache.MAP_KEY_PATH, newPathList.get(newPathList.size() - 1));
    }

Since instanceof checks cannot be done with generics (afaik, not a java pro here 😅 ) and a ClassCastException has to be thrown either way, if the value is not an ArrayList, I think it can be suppressed.

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#90811

Pre-launch Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the [CLA].
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
• I updated CHANGELOG.md to add a description of the change.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
• All existing and new tests are passing.

[bparrishMines]

LGTM with a small nit

[lukaskurz]

BTW, I wasn't sure where to ask this, but is the repo participating in the hacktoberfest ?

[bparrishMines]

@lukaskurz From my knowledge, we aren't participating in hacktoberfest. Unless @stuartmorgan has heard something different.

[stuartmorgan]

BTW, I wasn't sure where to ask this, but is the repo participating in the hacktoberfest ?

No. The page you linked to explains how to tell; we don't have that topic on the repo.

[lukaskurz]

@stuartmorgan To be honest, I was kinda hoping for the hacktoberfest-accepted label, since that does not require the topic to be added 😅 But it's not a problem, I can totally understand why you would not want to pollute the existing labels with another label just for some FOSS event.

Thanks for accepting the PR 👍

[stuartmorgan]

It's not a question of label pollution. We are not participating because our experience with the event (which in the past was not opt-in) has not been positive.

[lukaskurz]

@stuartmorgan Oh, i did not know that. May I ask what that bad experience entailed ? I'm guessing there probably is an influx of low-quality/low-effort PRs.

Edit: Admittedly such as adding a single @SuppressWarning(...) 😅

[stuartmorgan]

I'm guessing there probably is an influx of low-quality/low-effort PRs.

Yes.

Edit: Admittedly such as adding a single @SuppressWarning(...) 😅

No, fixing warnings is useful. It was mostly completely pointless README changes.