This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Don't fail an incremental build if can't find a merge base #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an additional check and warning message
2 tasks
goderbauer
reviewed
Mar 28, 2018
script/incremental_build.sh
Outdated
| FLUTTER_CHANGED_PACKAGES=`git diff --name-only $BRANCH_BASE_SHA HEAD | grep -o "packages/[^/]*" | sed -e "s/packages\///g" | sort | uniq | paste -s -d, -` | ||
|
|
||
| FLUTTER_CHANGED_GLOBAL=0 | ||
| FLUTTER_CHANGED_GLOBAL="" |
There was a problem hiding this comment.
Is it intentional to first assign 0 and then empty string?
There was a problem hiding this comment.
Good catch! It's a typo. It suppose to be FLUTTER_CHANGED_PACKAGES. Updated the PR.
goderbauer
reviewed
Mar 28, 2018
script/incremental_build.sh
Outdated
| FLUTTER_CHANGED_GLOBAL=`git diff --name-only $BRANCH_BASE_SHA HEAD | grep -v packages | wc -l` | ||
| FLUTTER_CHANGED_PACKAGES=`git diff --name-only $BRANCH_BASE_SHA HEAD | grep -o "packages/[^/]*" | sed -e "s/packages\///g" | sort | uniq | paste -s -d, -` | ||
| else | ||
| echo "Cannot find a merge base for the current branch to run an incremental build!" |
There was a problem hiding this comment.
Can you add to this message what would be required to make the build incremental (e.g. rebase, maybe?)?
|
@goderbauer added an actionable message 🙏 |
|
LGTM Travis failed, I assume its a flake. I restarted it, will merge on green. |
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional check and a warning message.
This change addresses an issue experienced in #423.
/cc @goderbauer