Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci.yaml] Main branch support #4440

Merged
merged 1 commit into from
Oct 27, 2021
Merged

[ci.yaml] Main branch support #4440

merged 1 commit into from
Oct 27, 2021

Conversation

CaseyHillers
Copy link

@CaseyHillers CaseyHillers commented Oct 20, 2021 •
edited
Loading

  • Redirect to Cocoon's main branch for the documentation
  • Enable main on the infra config (supports at a later time easily flipping the branches)

flutter/flutter#90476

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Oct 20, 2021
godofredoc
godofredoc reviewed Oct 20, 2021
View reviewed changes
.ci.yaml
enabled_branches:
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to create the new branches and setup the mirroring before landing this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, and it isn't a blocker to this change. I figured I would send these updates as I was fixing the last references to cocoon's master branch to make the switch easier.

@CaseyHillers
Copy link
Author

Friendly ping

@CaseyHillers CaseyHillers added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Oct 27, 2021
@fluttergithubbot fluttergithubbot merged commit 34caa5f into master Oct 27, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull request Oct 27, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
6552a1c 
* master:
  [ci.yaml] Main branch support (flutter#4440)
  [video_player] Initialize player when size and duration become available (flutter#4438)
  [webview_flutter] Implement zoom enabled for ios and android (flutter#4417)
  Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (flutter#4453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 28, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 28, 2021
@engine-flutter-autoroll
34caa5f [ci.yaml] Main branch support (flutter/plugins#4440)
defa574
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@amantoux
[ci.yaml] Main branch support (flutter#4440)
bf873fd
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@KyleFin
[ci.yaml] Main branch support (flutter#4440)
9b96e68
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@godofredoc godofredoc godofredoc approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@CaseyHillers @godofredoc @fluttergithubbot