This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Add supporting interfaces for setting cookies to platform interface. #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
p: webview_flutter
This was referenced Nov 29, 2021
BeMacized
commented
Nov 29, 2021
| @@ -59,6 +59,7 @@ abstract class WebViewPlatform { | |||
| /// Clears all cookies for all [WebView] instances. | |||
| /// | |||
| /// Returns true if cookies were present before clearing, else false. | |||
| @Deprecated('Use `WebViewCookieManagerPlatform.clearCookies` instead.') | |||
There was a problem hiding this comment.
@ reviewer: Just want to double check if it's ok to deprecate platform interface methods like this?
There was a problem hiding this comment.
You can't deprecate methods we're still using; it breaks the tree. (I should have tooling soon that will catch this kind of thing in CI.)
They can be commented as deprecated, and then actually deprecated later once the uses have been removed.
Unless you can fix the call sites right away, we need to revert this part, as this will close not only our tree, but the flutter/flutter tree as well.
There was a problem hiding this comment.
@stuartmorgan Alright, I'll quickly submit a PR that changes this annotation to a comment.
mvanbeusekom
suggested changes
Nov 30, 2021
packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/webview_cookie.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/webview_cookie.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/webview_cookie.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/webview_cookie.dart
Outdated
Show resolved
Hide resolved
11 tasks
BeMacized
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 2, 2021
…es to platform interface. (flutter/plugins#4555)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 2, 2021
…es to platform interface. (flutter/plugins#4555)
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…atform interface. (flutter#4555)
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…atform interface. (flutter#4555)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
clearCookieswas moved here, andsetCookiewas added.WebViewPlatformcauses breaking changes due to [webview_flutter] Update to standard platform interface structure flutter#94051. Having a separate cookie manager should prevent this.clearCookiesmade this rather difficult.CreationParamshas been expanded to also contain initial cookies to be set upon creation of the webview.clearCookiesinWebViewPlatformhas been deprecated in favour ofWebViewCookieManager.clearCookies.Relevant issue:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.