This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Add Android implementations for new cookie manager, to allow setting cookies directly and on webview creation. #4557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: webview_flutter
…ter/set_cookies_android
…ter/set_cookies_android
…ter/set_cookies_android
…ter/set_cookies_android
11 tasks
…et_cookies_android
mvanbeusekom
suggested changes
Dec 6, 2021
| @@ -111,6 +110,7 @@ private void setUp( | |||
| binaryMessenger, | |||
| new WebSettingsHostApiImpl( | |||
| instanceManager, new WebSettingsHostApiImpl.WebSettingsCreator())); | |||
| GeneratedAndroidWebView.CookieManagerHostApi.setup(binaryMessenger, cookieManagerHostApi); | |||
There was a problem hiding this comment.
nit: isn't GeneratedAndroidWebView obsolete here?
There was a problem hiding this comment.
Not really judging by the other lines before it, but I imported it in a different way. Changing it to be similar to the others.
...er_android/android/src/main/java/io/flutter/plugins/webviewflutter/WebViewFlutterPlugin.java
Show resolved
Hide resolved
...ndroid/android/src/main/java/io/flutter/plugins/webviewflutter/CookieManagerHostApiImpl.java
Outdated
Show resolved
Hide resolved
...ndroid/android/src/main/java/io/flutter/plugins/webviewflutter/CookieManagerHostApiImpl.java
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/src/android_webview.dart
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/webview_android.dart
Outdated
Show resolved
Hide resolved
This reverts commit 6d79274.
BeMacized
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2021
…manager, to allow setting cookies directly and on webview creation. (flutter/plugins#4557)
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
… to allow setting cookies directly and on webview creation. (flutter#4557)
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
… to allow setting cookies directly and on webview creation. (flutter#4557)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementations for the new cookie manager to the Android package.
As this PR depends on, and contains the changes of, updates made to the platform interface in #4555, this PR will remain in draft mode until those changes have been merged and published.Relevant issue:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.