This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Expose loadFile and loadHtmlString through app facing package. #4558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `loadData` and `loadDataWithBaseUrl` methods to the pigeon communication interface. Next step would be to include the implementation details on the Android (JAVA) side.
Adds the native Android implementation for the `loadData` and `loadDataWithBaseUrl` API methods.
Adds the Dart implementation of Android's WebView `loadData` and `loadDataWithBaseUrl` methods. Also fixed support for null parameters in the native Android implementation.
Adds implementation to the `WebViewController` class to expose the `WebViewPlatformController.loadFile` and `WebViewPlatformController.loadHtmlString` methods.
Adds unit tests for the `loadFile` and `loadHtmlString` methods which are added to the `WebViewController` class in commit f8e9c32.
Adds example implementation of the `WebViewController.loadHtmlString` and `WebViewController.loadFile` methods to the example app.
Updates the version of the app facing plugin to 2.4.0 and adds a matching entry to the CHANGELOG.md.
github-actions
bot
added
p: webview_flutter
11 tasks
mvanbeusekom
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2021
…app facing package. (flutter/plugins#4558)
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]: This PR has a dependency on PR #4544. The
webview_flutter/pubspec.yamlneeds to be updated once that PR has landed.Adds implementation to the
WebViewControllerclass to expose theWebViewPlatformController.loadFileandWebViewPlatformController.loadHtmlStringmethods.Related to issues:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).