Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add ui configuration api #492

Merged
merged 6 commits into from
Apr 13, 2018
Merged

Conversation

mravn-google
Copy link
Contributor

  • Add API for setting and querying GoogleMapOptions/UiSettings
  • Refactor Java code into three classes (plugin, MapView controller, json conversion code)
  • Rename model.dart to location.dart to reflect file content

Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// Configuration options for the GoogleMaps user interface.
///
/// When used to change configuration, null values will be interpreted as
/// do not change this configuration item. When used to represent current
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps quote "do not change this configuration item"

@mravn-google mravn-google merged commit 8eccba4 into flutter:master Apr 13, 2018
@mravn-google mravn-google deleted the map_ui_api branch April 13, 2018 13:21
slightfoot pushed a commit to slightfoot/plugins that referenced this pull request Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants