This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add constructor VideoPlayerController.file() #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szakarias
approved these changes
Apr 15, 2018
packages/video_player/pubspec.yaml
Outdated
| @@ -2,7 +2,7 @@ name: video_player | |||
| description: Flutter plugin for displaying inline video with other Flutter | |||
| widgets on Android and iOS. | |||
| author: Flutter Team <flutter-dev@googlegroups.com> | |||
| version: 0.4.1 | |||
| version: 0.5.1 | |||
| @@ -133,7 +140,10 @@ class VideoPlayerValue { | |||
| class VideoPlayerController extends ValueNotifier<VideoPlayerValue> { | |||
| int _textureId; | |||
| final String dataSource; | |||
| final bool isNetwork; | |||
|
|
|||
| /// Describes the type of data source this is constructed with. | |||
There was a problem hiding this comment.
nit: this -> this VideoPlayerController
sigurdm
commented
Apr 16, 2018
| @@ -133,7 +140,10 @@ class VideoPlayerValue { | |||
| class VideoPlayerController extends ValueNotifier<VideoPlayerValue> { | |||
| int _textureId; | |||
| final String dataSource; | |||
| final bool isNetwork; | |||
|
|
|||
| /// Describes the type of data source this is constructed with. | |||
packages/video_player/pubspec.yaml
Outdated
| @@ -2,7 +2,7 @@ name: video_player | |||
| description: Flutter plugin for displaying inline video with other Flutter | |||
| widgets on Android and iOS. | |||
| author: Flutter Team <flutter-dev@googlegroups.com> | |||
| version: 0.4.1 | |||
| version: 0.5.1 | |||
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
Add constructor VideoPlayerController.file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes flutter/flutter#16444.