Add ability to create games sign in #511

ihildebrandt · 2018-04-30T02:24:06Z

This introduces an additional init argument so that a games sign in experience can be created in Android. The native iOS code will return an error if attempting to create a games sign in.

Additionally, the Android plugin publishes the GoogleSignInAccount so that it can be accessed by other native code.

mravn-google

Thanks for the contribution!

mravn-google · 2018-04-30T05:46:23Z

packages/google_sign_in/lib/google_sign_in.dart

+  /// Equivalent to GoogleSignInOptions.DEFAULT_SIGN_IN
+  static const String defaultSignInOptions = "defaultSignIn";
+
+  /// Equivalent to GoogleSignInOptions.DEFAULT_GAMES_Sign_In


Should be DEFAULT_GAMES_SIGN_IN

mravn-google · 2018-04-30T05:54:08Z

packages/google_sign_in/lib/google_sign_in.dart

+  static const String defaultGamesSignInOptions = "defaultGamesSignIn";
+
+  /// The options to pass to GoogleSignInOptions.Builder()
+  final String builderOptions;


This property is named after an implementation detail on the Android side (the builder). Maybe rename to defaultConfiguration, signInOptions or similar? Renaming should be done also for the MethodChannel argument name.

The String type may be too wide. Perhaps use an enum instead?

mravn-google · 2018-04-30T05:59:17Z

packages/google_sign_in/lib/google_sign_in.dart

@@ -142,7 +151,21 @@ class GoogleSignIn {
  /// The [hostedDomain] argument specifies a hosted domain restriction. By
  /// setting this, sign in will be restricted to accounts of the user in the
  /// specified domain. By default, the list of accounts will not be restricted.
-  GoogleSignIn({this.scopes, this.hostedDomain});
+  GoogleSignIn({this.builderOptions, this.scopes, this.hostedDomain});


We may want to assert that the builderOptions has a valid value. (With an enum rather than a String we don't need that.)

mravn-google · 2018-04-30T06:08:01Z

...google_sign_in/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

@@ -380,6 +403,7 @@ private void onSignInResult(GoogleSignInResult result) {
      if (result.isSuccess()) {
        GoogleSignInAccount account = result.getSignInAccount();
        currentAccount = account;
+        registrar.publish(account);


We were planning to deprecate the value publishing API. Can't potential clients use the GoogleSignIn API directly to get the account?

mravn-google · 2018-04-30T06:08:51Z

...google_sign_in/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

-            new GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN).requestEmail();
+        GoogleSignInOptions.Builder optionsBuilder;
+
+        if (builderOptions == null) builderOptions = DEFAULT_SIGN_IN;


This should not be necessary, as we ensure the parameter has a non-null value on the Dart side.

ihildebrandt · 2018-04-30T14:05:24Z

@mravn-google Thanks for the review. I believe I addressed all of your notes. Swapping to a direct API call in my downstream plugin worked.

Let me know if there's anything else I can clean up.

mravn-google · 2018-04-30T19:41:15Z

packages/google_sign_in/ios/Classes/GoogleSignInPlugin.m

-      result([FlutterError errorWithCode:@"missing-config"
-                                 message:@"GoogleService-Info.plist file not found"
+    if ([((NSNumber *)call.arguments[@"signInOption"]) isEqualToNumber:[NSNumber
+                                                                           numberWithInt:1]]) {


Maybe simpler with

NSNumber* signInOption = call.arguments[@"signInOption"]; if ([signInOption intValue] == 1) { ... }

mravn-google

Thanks. Added some additional comments.

mravn-google · 2018-04-30T19:43:13Z

packages/google_sign_in/lib/google_sign_in.dart

@@ -127,6 +129,9 @@ class GoogleSignIn {
  static const MethodChannel channel =
      const MethodChannel('plugins.flutter.io/google_sign_in');

+  /// The options to pass to GoogleSignInOptions.Builder()


We should not mention the Android API's builder here, but instead document what SignInOption is, in its own right. And we should document that gamesSignIn isn't supported on iOS.

mravn-google · 2018-04-30T19:44:42Z

packages/google_sign_in/lib/google_sign_in.dart

-  GoogleSignIn({this.scopes, this.hostedDomain});
+  GoogleSignIn({this.signInOption, this.scopes, this.hostedDomain});
+
+  /// Factory for creating default sign in


[nit] Dartdoc opening paragraph should end in a .

Same for GoogleSignIn.gamesSignIn below.

mravn-google · 2018-04-30T19:44:57Z

packages/google_sign_in/lib/google_sign_in.dart

+        hostedDomain: hostedDomain);
+  }
+
+  /// Factory for creating sign in suitable for games


Please document that this does not work on iOS.

mravn-google · 2018-04-30T19:51:56Z

packages/google_sign_in/lib/google_sign_in.dart

@@ -13,6 +13,8 @@ import 'src/common.dart';
 export 'src/common.dart';
 export 'widgets.dart';

+enum SignInOption { defaultSignIn, gamesSignIn }


Maybe call these standard and games. The SignIn part is already given by the enum type name.

mravn-google · 2018-04-30T19:53:30Z

packages/google_sign_in/lib/google_sign_in.dart

+  GoogleSignIn({this.signInOption, this.scopes, this.hostedDomain});
+
+  /// Factory for creating default sign in
+  factory GoogleSignIn.defaultSignIn(


Maybe rename the factory constructors GoogleSignIn.standard and GoogleSignIn.games, again to avoid repeating the SignIn part in client code.

mravn-google · 2018-04-30T19:56:47Z

packages/google_sign_in/lib/google_sign_in.dart

@@ -173,7 +192,8 @@ class GoogleSignIn {

  Future<void> _ensureInitialized() {
    if (_initialization == null) {
-      _initialization = channel.invokeMethod("init", <String, dynamic>{
+      _initialization = channel.invokeMethod('init', <String, dynamic>{
+        'signInOption': (signInOption ?? SignInOption.defaultSignIn).index,


Maybe keep this as a String in the channel communication and on the platform side. 0 and 1 are just magic constants otherwise, with non-obvious relationship to the Dart enum.

mravn-google

LGTM

mravn-google · 2018-05-01T05:26:42Z

Thanks a lot! Can I ask you to address the compile error and formatting discrepancies reported by Travis?

mravn-google · 2018-05-01T05:30:29Z

packages/google_sign_in/ios/Classes/GoogleSignInPlugin.m

-                                 message:@"Games sign in is not supported on iOS"
-                                 details:nil]);
+    NSString *signInOption = call.arguments[@"signInOption"];
+    if ([signInOption isEqualToString] == @"SignInOption.games") {


Oops. You meant [sigInOption isEqualtoString:@"SignInOption.games"] :-)

mravn-google · 2018-05-01T13:56:37Z

Published after #519

googlebot added the cla: yes label Apr 30, 2018

ihildebrandt force-pushed the ihildebrandt/games_sign_in branch 2 times, most recently from b0a7574 to b318fc8 Compare April 30, 2018 02:55

add ability to create games sign in

b0aead4

ihildebrandt force-pushed the ihildebrandt/games_sign_in branch from b318fc8 to b0aead4 Compare April 30, 2018 03:05

mravn-google reviewed Apr 30, 2018

View reviewed changes

mravn-google self-assigned this Apr 30, 2018

ihildebrandt force-pushed the ihildebrandt/games_sign_in branch 2 times, most recently from 4bd76da to f66a147 Compare April 30, 2018 19:17

mravn-google reviewed Apr 30, 2018

View reviewed changes

remove publish call, use enum rather than string

e65ec7a

ihildebrandt force-pushed the ihildebrandt/games_sign_in branch from 5338b6a to e65ec7a Compare April 30, 2018 20:07

documentation, pass string in native call

15e4a91

mravn-google approved these changes May 1, 2018

View reviewed changes

mravn-google reviewed May 1, 2018

View reviewed changes

formatting fixes

fd38c40

ihildebrandt force-pushed the ihildebrandt/games_sign_in branch from e136849 to fd38c40 Compare May 1, 2018 12:59

mravn-google merged commit 31e298a into flutter:master May 1, 2018

mravn-google mentioned this pull request May 1, 2018

Update metadata for pub #519

Merged

ihildebrandt deleted the ihildebrandt/games_sign_in branch May 1, 2018 15:03

haydenflinner pushed a commit to haydenflinner/plugins that referenced this pull request May 4, 2018

Add ability to create games sign in (flutter#511)

98cb2bb

slightfoot pushed a commit to slightfoot/plugins that referenced this pull request Jun 5, 2018

Add ability to create games sign in (flutter#511)

ef4741f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to create games sign in #511

Add ability to create games sign in #511

ihildebrandt commented Apr 30, 2018

mravn-google left a comment

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

ihildebrandt commented Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google left a comment

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google Apr 30, 2018

mravn-google left a comment

mravn-google commented May 1, 2018 •

edited

Loading

mravn-google May 1, 2018

mravn-google commented May 1, 2018

Add ability to create games sign in #511

Add ability to create games sign in #511

Conversation

ihildebrandt commented Apr 30, 2018

mravn-google left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ihildebrandt commented Apr 30, 2018

Choose a reason for hiding this comment

mravn-google left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mravn-google left a comment

Choose a reason for hiding this comment

mravn-google commented May 1, 2018 • edited Loading

Choose a reason for hiding this comment

mravn-google commented May 1, 2018

mravn-google commented May 1, 2018 •

edited

Loading