Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add send verification mail #529

Merged

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented May 3, 2018

Add the method to send verification email to user.
Refers to issue flutter/flutter#12459

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@imtoori
Copy link
Contributor Author

imtoori commented May 3, 2018

Ok, Google! I signed It!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 3, 2018
@mravn-google
Copy link
Contributor

Thanks for the contribution! Can I ask you to

  • add a unit test of the Dart code to test/firebase_auth_test.dart
  • bump the version field in pubspec.yaml
  • add a corresponding entry to CHANGELOG.md

@imtoori imtoori force-pushed the feature/send-verification-email branch from cd1ee0b to c63a495 Compare May 4, 2018 09:04

* Added support for linkWithFacebookCredential

## 0.5.6

* Added support to sendEmailVerification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the 0.5.7 addition, right? (Merge mixup?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry :/

@mravn-google mravn-google changed the title add send verification mail Add send verification mail May 4, 2018
@@ -78,6 +78,10 @@ class FirebaseUser extends UserInfo {
});
}

Future<void> sendEmailVerification() async {
return await FirebaseAuth.channel.invokeMethod('sendEmailVerification');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return is confusing here and can be deleted.

Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mravn-google mravn-google merged commit 9d72be7 into flutter:master May 4, 2018
@mravn-google
Copy link
Contributor

mravn-google commented May 4, 2018

I'll publish once #530 lands.
Done. Thanks again for the contribution!

haydenflinner pushed a commit to haydenflinner/plugins that referenced this pull request May 4, 2018
slightfoot pushed a commit to slightfoot/plugins that referenced this pull request Jun 5, 2018
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants