Add timeout properties to FirebaseStorage #532
Conversation
szakarias
force-pushed
the
firebaseStorage2
branch
from
720cdb1
to
5d630e6
Compare
szakarias
force-pushed
the
firebaseStorage2
branch
from
5d630e6
to
1ae8689
Compare
|
|
||
| - (void)setMaxDownloadRetryTime:(FlutterMethodCall *)call result:(FlutterResult)result { | ||
| NSNumber *time = call.arguments[@"time"]; | ||
| storage.maxDownloadRetryTime = [time longLongValue] / 1000; |
There was a problem hiding this comment.
If time is 500ms, you'd end up with 0 because of integer division. You should divide by 1000.0.
| @@ -44,6 +48,60 @@ class FirebaseStorage { | |||
| /// Creates a new [StorageReference] initialized at the root | |||
| /// Firebase Storage location. | |||
| StorageReference ref() => new StorageReference._(const <String>[], this); | |||
|
|
|||
| Future<int> getMaxDownloadRetryTimeMillis() async { | |||
| final num n = await channel.invokeMethod( | |||
There was a problem hiding this comment.
This should always be an int.
| if ([@"StorageReference#putFile" isEqualToString:call.method]) { | ||
| storage = [self getStorage:call]; | ||
| if ([@"FirebaseStorage#getMaxDownloadRetryTime" isEqualToString:call.method]) { | ||
| result(@((long)storage.maxDownloadRetryTime * 1000.0)); |
There was a problem hiding this comment.
(int64_t)(storage.xxx * 1000)
| break; | ||
| case "FirebaseStorage#setMaxOperationRetryTime": | ||
| setMaxOperationTimeMillis(call, result); | ||
| break; |
There was a problem hiding this comment.
Alternatively, reduce to set/getRetryTime(maxDownload, maxUpload, maxOperation) to avoid a platform channel invocation per value.
| 'app': app?.name, | ||
| 'bucket': storageBucket, | ||
| }); | ||
| return n.toInt(); |
There was a problem hiding this comment.
... and then you can just return n.
|
|
||
| NSMutableDictionary *bucketMap = _storageMap[app.name]; | ||
| if (!bucketMap) { | ||
| bucketMap = [[NSMutableDictionary alloc] init]; |
There was a problem hiding this comment.
Maybe [NSMutableDictionary dictionaryWithCapacity:1].
| NSString *bucketName = [url host]; | ||
| FIRStorage *storage = bucketMap[bucketName]; | ||
| if (!storage) { | ||
| // Raises an exception if bucketUrl is invalid. |
There was a problem hiding this comment.
That exception never reaches Dart. Is there any way to get an NSError from a FIRStorage constructor?
| @@ -80,6 +84,68 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result | |||
| } | |||
| } | |||
|
|
|||
| - (FIRStorage *)getStorage:(FlutterMethodCall *)call { | |||
There was a problem hiding this comment.
Please add a comment on why this method doesn't just return [FIRStorage x y].
No description provided.