This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Breaking changes to signature of snapshots and setData in cloud_firestore #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
approved these changes
May 4, 2018
| ## 0.7.0 | ||
|
|
||
| * **Breaking change**. snapshots is now a method instead of a getter. | ||
| * **Breaking change**. setData uses optional arguments instead of SetOptions. |
There was a problem hiding this comment.
Maybe use code font on snapshots, setData, and SetOptions to avoid having the entry look like a spelling error with lowercase word following the full stop.
[nit] optional arguments => named argument?
| /// document does not yet exist, it will be created. | ||
| /// | ||
| /// If [merge] is true, the provided data will be merged into an | ||
| /// existing document. |
There was a problem hiding this comment.
Please document the default semantics: overwrite?
| @@ -61,10 +61,10 @@ class WriteBatch { | |||
| /// | |||
| /// If the document does not yet exist, it will be created. | |||
| /// | |||
| /// If you pass [SetOptions], the provided data will be merged into an | |||
| /// If [merge] is true, the provided data will be merged into an | |||
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
…tore (flutter#536) These changes are required to support the metadata argument to snapshots and other future API changes.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…tore (flutter#536) These changes are required to support the metadata argument to snapshots and other future API changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.