This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Graduate admob plugin to beta #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
reviewed
May 5, 2018
packages/firebase_admob/README.md
Outdated
| @@ -4,8 +4,7 @@ A plugin for [Flutter](https://flutter.io) that supports loading and | |||
| displaying banner, interstitial (full-screen), and rewarded video ads using the | |||
| [Firebase AdMob API](https://firebase.google.com/docs/admob/). | |||
|
|
|||
| *Warning*: This plugin is still under development, some AdMob features are not | |||
| available yet and testing has been limited. | |||
| *Note*: This plugin is is beta, and may still have a few issues and missing APIs. | |||
|
Is there a reason why you choose this version number? 0.5.4+1 would be more accurate under semantic versioning since this is a documentation-only change. |
|
I thought we used that (0.9) as a convention for packages that hit beta? |
|
I was not aware of such a convention. If one exists I'd love to know more so I can do the same for other beta plugins. Per our conversation I'll land it as 0.5.4+1 but feel free to bump to 0.9 in the future if it makes sense to do so. |
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.