Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Split files into library structure. #550

Merged
merged 1 commit into from
May 7, 2018

Conversation

pauldemarco
Copy link
Contributor

@pauldemarco pauldemarco commented May 7, 2018

As per request by @szakarias in PR #531.

This does not include any changes from #531 regarding upload monitoring.

@collinjackson
Copy link
Contributor

lgtm, we should add missing dartdoc but that can be done in a separate PR.

I'm on the fence as to whether UploadTaskSnapshot should have its own file

@pauldemarco
Copy link
Contributor Author

pauldemarco commented May 7, 2018

@collinjackson I agree, I did that in anticipation of #531

Let me know if you'd like me to combine this back in for now.

Edit: Ah you're referring to the snapshot, I think that would be a good idea. iOS uses a FIRStorageTaskSnapshot for both uploading and downloading, Android uses a UploadTask.TaskSnapshot for uploading and a FileDownloadTask.TaskSnapshot for downloading, but I think it's safe to say we can combine on dart side.

@szakarias szakarias self-assigned this May 7, 2018
@szakarias
Copy link
Contributor

szakarias commented May 7, 2018

LGTM, I'm fine with keeping the upload_task.dart file as it is.

@collinjackson collinjackson merged commit e8dc380 into flutter:master May 7, 2018
@collinjackson
Copy link
Contributor

I've merged this, I think there's no need to release this as a separate version since the changes aren't visible to the developer but please do mention it in the CHANGELOG for #531

slightfoot pushed a commit to slightfoot/plugins that referenced this pull request Jun 5, 2018
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants