Update Remote Config plugin #551
Conversation
kroikie
commented
May 7, 2018
kroikie
commented
- Bump Android version
- iOS returns String status
- Bump Android version - iOS returns String status
| @@ -32,7 +32,6 @@ android { | |||
| disable 'InvalidPackage' | |||
| } | |||
| dependencies { | |||
| api 'com.google.firebase:firebase-config:[11.4.0,12.0[' | |||
| api 'com.google.firebase:firebase-core:[11.4.0,12.0[' | |||
| api 'com.google.firebase:firebase-config:15+' | |||
There was a problem hiding this comment.
Can you elaborate on why this is necessary, just for my own edification? (and maybe also the changelog's)
There was a problem hiding this comment.
All libraries from Google Play Services must be of the same version if used in the same app. We should devise a way to auto update all the plugins so they stay in sync.
There was a problem hiding this comment.
The other firebase plugins use 15.+. Shouldn't this do that as well?
There was a problem hiding this comment.
@bjon Correct, since the others are at 15 this one should also be at 15 otherwise other FlutterFire plugins can't be used with this one.
There was a problem hiding this comment.
@kroikie I mean 15.+, not 15+.
| @@ -1,3 +1,8 @@ | |||
| ## [0.0.2] | |||
|
|
|||
| * Fix iOS casting issue. | |||
There was a problem hiding this comment.
This is a bit vague, we might want to describe the APIs or behavior that was previously broken and now works
| ## [0.0.2] | ||
|
|
||
| * Fix iOS casting issue. | ||
| * Bump Android library version. |
There was a problem hiding this comment.
I would say something like "increase Android Firebase dependency to 15+" to be more specific about what you did here
|
lgtm |
* Update Remote Config plugin - Bump Android version to 15.+ - iOS returns fetch status as String
* Update Remote Config plugin - Bump Android version to 15.+ - iOS returns fetch status as String
