This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Adding null-safe handling for Transaction.get in cloud_firestore #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you `.get` a document that doesn't exist, the result's `data` is `null`. This is expected behavior. Transactions were attempting to `.cast` this to a Map without null-safety. This caused an error in transactions when getting a document that doesn't exist. A unit test was added to verify the fix.
killermonk
commented
May 9, 2018
| 'path': 'foo/bar', | ||
| 'data': <String, dynamic>{'key1': 'val1'} | ||
| }; | ||
| if (methodCall.arguments['path'] == 'foo/bar') { |
There was a problem hiding this comment.
This is now identical to DocumentReference#get on line 95
killermonk
added a commit
to flutter-institute/todomvc
that referenced
this pull request
May 9, 2018
updating to latest cloud_firestore updating to latest channel_mock NOTE: There is a test still failing because of a firestore bug, see flutter/plugins#558
|
Thanks for this PR! This looks good to me. |
|
Should be able to merge once #559 is in. @collinjackson Could you also have a look at this? |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you
.geta document that doesn't exist, the result'sdataisnull. This is expected behavior.Transactions were attempting to
.castthis to a Map without null-safety.This caused an error in transactions when getting a document that doesn't exist.
A unit test was added to verify the fix.