This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add video player buffering status #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case 'bufferingStart': | ||
| value = value.copyWith( | ||
| isBuffering: true, | ||
| ); |
There was a problem hiding this comment.
[nit] Here and below: we use trailing commas only when needed. And this statement easily fits on a single line:
value = value.copyWith(isBuffering: true);There was a problem hiding this comment.
Ah yeah sorry, force of habit. Will remove.
| } else if (context == playbackBufferFullContext) { | ||
| if (_eventSink != nil) { | ||
| _eventSink(@{@"event" : @"bufferingEnd"}); | ||
| } |
There was a problem hiding this comment.
This doesn't quite work. Running the example app on my iOS device, the circular progress indicator is activated, but then stays active throughout playback.
I guess if the video fits in the buffer, the playbackBufferFull property never changes. So we probably have to fire the bufferingEnd event also on playbackLikelyToKeepUp.
There was a problem hiding this comment.
Alright, gonna add that.
|
Published, thanks again! |
|
Thanks for reviewing 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added property to know whether video player is currently buffering or not. I need this to show
CircularProgressIndicatorif the video is currently buffering. I haven't tested for the IOS because I don't have the devices so if anyone can test it, please do.