This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
image_picker fixes: file suffix, permissions redirect, video resize #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
reviewed
Jun 7, 2018
| } | ||
|
|
||
| private void handleChoosePictureResult(int resultCode, Intent data) { | ||
| private void handleChooseMediaResult(int resultCode, Intent data, boolean isResizable) { |
There was a problem hiding this comment.
Please consider breaking this method and the ones below in two to avoid the boolean argument. E.g. handleChooseImageResult and handleChooseVideoResult. I'd rather suffer a few lines of repeated code between the image vs video cases than having multiple methods whose boolean argument reveal that each does two things.
It doesn't seem unlikely that the image vs video case might drift further apart in the future.
|
Hi @wreppun, thanks for contributing; have you had a chance to consider the review feedback? |
|
Hey, yes, thanks for the feedback. I don't mind breaking those up -- I should be able to look at this and turn something around on Tuesday. |
|
Published |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for three bugs relating to image picker. I found the latter two when fixing the first. I'm happy to split this up if that's easier.
.pngextension. I'm not 100% sure that.jpgand.mp4are correct -- I couldn't find an authoritative source -- but that's what most information seemed to point towards.