video_player: autodetect video source format #613
Conversation
Use the file/url extension to detect the source format and accordingly create the right media sources
pyrossh
changed the title
|
@googlebot assign reviewer please. |
|
@pyros2097 Thanks for this PR! Been trying fruitlessly to get HLS streams working on flutter all day till I saw this. Hope it gets merged soon. |
|
@anupcowkur Yeah man, Even I need this to be merged. So what I did now is add the platform channel in my app directly. Couldn't wait for this to be merged to test it out. |
|
@mravn-google Done. Thank you. |
| new AspectRatioVideo(controller), | ||
| ), | ||
| new NetworkPlayerLifeCycle( | ||
| 'http://live.cloud6.in:1935/simskasri/limitless/playlist.m3u8', |
There was a problem hiding this comment.
I think we need something less controversial here. I don't know this feed, but the first thing I got when I tried it was a preacher.
Alternatively, the example app can just keep using the .mp4 file only.
There was a problem hiding this comment.
Sure. I've changed it to a big buck bunny hls stream.
There was a problem hiding this comment.
It's hard to control the top video without interfering with the bottom one. They seem to be too close. Can I ask you to add some padding?
|
Oh man... too late someone else bumped the version to 0.6.2 and pushed sad. |
|
0.6.3 has been released as well. You might want to rebase and bump to 0.6.4 ;) |
|
6.3 is already out. I'll hold back on more pushes until we've landed yours. |
|
Haha... Yeah... Just figured that out. Thanks btw. |
|
This seems like the wrong approach... shouldn't we be dispatching based on the headers we receive from the server, rather than the extension? Paths in URLs are supposed to be opaque. |
|
@Hixie Yes you are right. That would be the ideal solution. But then it is also possible to not send the right header so at that point we would need to fallback on the extension or manually provided format type. Also didn't dig into how to implement it using headers. |
|
isHLS from #607 ... I want it back. It works well with JWPlayer but not with the video_player plugin :-( I have filed a detailed issue on this, @pyros2097 can you please look into this. |
Use the file/url extension to detect the source format and accordingly create the right media sources