This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Shard plugins for example app builds #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
commented
Jun 17, 2018
| script: | ||
| - ./script/plugin_tools.sh build-examples --apk | ||
| - ./script/plugin_tools.sh java-test # must come after apk build | ||
| # Job 4) Build example IPAs | ||
| # Job 3.2) Build example APKs and run Java tests, shard 2/2 |
There was a problem hiding this comment.
I would have liked to avoid duplication here, but not sure what is the best approach for that.
goderbauer
approved these changes
Jun 23, 2018
fkorotkov
reviewed
Jun 25, 2018
| echo "Running for all packages" | ||
| pub global run flutter_plugin_tools "$@" | ||
| echo "Running for all packages ($PLUGIN_SHARDING)" | ||
| pub global run flutter_plugin_tools "$@" $PLUGIN_SHARDING | ||
| else | ||
| echo "Running only for $FLUTTER_CHANGED_PACKAGES" | ||
| pub global run flutter_plugin_tools "$@" --plugins=$FLUTTER_CHANGED_PACKAGES |
There was a problem hiding this comment.
@mravn-google should $PLUGIN_SHARDING be added here as well?
There was a problem hiding this comment.
That wasn't my original intention, as this branch usually means a small number of plug-ins. Trouble is, the Travis config spawns the same number of jobs either way, so we end up with redundant execution.
There was a problem hiding this comment.
Got it! I was just wondering if $PLUGIN_SHARDING was missed here.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of sharding parameters in
flutter_plugin_tools, with shard count = 2.My .travis.yaml fu is obviously weak, and I have not yet had time to find a better approach that has less duplication of configuration and doesn't result in two shards also when there is only one plugin involved in the CI run.