This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
video_player: Allow audio playback in silent mode #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mravn-google done ;) |
|
This branch seems to need a rebase now. Sorry. |
This is the default behaviour of video apps on iOS. (fixes flutter/flutter#17911)
|
No worries. Branch has been rebased. |
|
Thanks. Of course your two PRs are now conflicting... |
|
Was to be expected yes. Merged in the master branch again. |
|
As the other PR has already been released I bumped the version again. Also fixed a small typo in the changelog. |
najeira
added a commit
to najeira/flutter-video-player
that referenced
this pull request
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default behaviour of video apps on iOS.
(fixes flutter/flutter#17911)
I considered setting the category back to
AVAudioSessionCategorySoloAmbientondisposebut this led to race conditions when switching between videos.