-
Notifications
You must be signed in to change notification settings - Fork 9.8k
add didReceiveRegistrationToken to firebase_messaging on ios #625
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Signed It |
CLAs look good, thanks! |
Hi @urbandove thank you for the PR. You are correct that we should implement |
@kroikie Done Probably should bump the version of firebase_messaging with this change |
@urbandove yes please bump the version number as well as make a CHANGELOG entry, thanks! |
@kroikie Done |
@urbandove thanks! Looks good to merge. |
…#625) Updated iOS token hook from 'didRefreshRegistrationToken' to 'didReceiveRegistrationToken'
Currently on ios on app startup FCM throws an error that didReceiveRegistrationToken is not set up and when attempting to get a token using the getToken function it will often hang without returning a token. (When using await will hang and when using a callback will never call the callback)
Adding this has fixed the issue