Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

add didReceiveRegistrationToken to firebase_messaging on ios #625

Merged
merged 3 commits into from
Jun 19, 2018

Conversation

urbandove
Copy link
Contributor

Currently on ios on app startup FCM throws an error that didReceiveRegistrationToken is not set up and when attempting to get a token using the getToken function it will often hang without returning a token. (When using await will hang and when using a callback will never call the callback)

Adding this has fixed the issue

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@urbandove
Copy link
Contributor Author

Signed It

@googlebot
Copy link

CLAs look good, thanks!

@kroikie kroikie self-assigned this Jun 18, 2018
@kroikie
Copy link
Contributor

kroikie commented Jun 19, 2018

Hi @urbandove thank you for the PR. You are correct that we should implement didReceiveRegistrationToken. Could you also remove didRefreshRegistrationToken? That method has been removed and should not be used.

@urbandove
Copy link
Contributor Author

@kroikie Done

Probably should bump the version of firebase_messaging with this change

@kroikie
Copy link
Contributor

kroikie commented Jun 19, 2018

@urbandove yes please bump the version number as well as make a CHANGELOG entry, thanks!

@urbandove
Copy link
Contributor Author

@kroikie Done

@kroikie
Copy link
Contributor

kroikie commented Jun 19, 2018

@urbandove thanks! Looks good to merge.

@kroikie kroikie merged commit 12d8a0c into flutter:master Jun 19, 2018
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…#625)

Updated iOS token hook from 'didRefreshRegistrationToken' to 'didReceiveRegistrationToken'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants