This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Adds nonPersonalizedAds option to MobileAdTargetingInfo for firebase_admob #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kroikie for review |
|
LGTM! Bumping version then merging. |
kroikie
force-pushed
the
firebase-admob-npa
branch
from
4f47dc1
to
42f85c8
Compare
kroikie
approved these changes
Aug 24, 2018
nichtverstehen
pushed a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 6, 2018
…admob (flutter#638) * Adds nonPersonalizedAds option to MobileAdTargetingInfo * Formats code * Bump version
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…admob (flutter#638) * Adds nonPersonalizedAds option to MobileAdTargetingInfo * Formats code * Bump version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the light of recent events, namely GDPR, I was missing the functionality to request non-personalized ads in the firebase_admob plugin. This PR adds this option and the respective Android/iOS platform specific code (as described in the Google Mobile Ads SDK).
I also added
nonPersonalizedAds: trueto the example. Unfortunately there currently is no way in the GMA SDK to programmatically check if the requested ad is in fact non-personalized - so no test exists right now.This is my first contribution, so it's likely I missed something. Please let me know if that's the case - thanks! 👍
This feature was requested/asked for in Issue #17542 [main flutter repo].