-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Unregister the activity lifecycle callbacks when disposing the camera #645
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it |
CLAs look good, thanks! |
@kmorkos I have just checked your fix by changing pubspec.yaml as you mentioned in flutter/flutter#18348, and it fixed the first error, however introduced another one. I wonder if it has something to do with the CameraPreview I am using. There is no way to dispose that 😢. This happens after I leave the camera page and go back to previous page. Immediately the error occurs. Should I file a new issue? This is the stacktrace:
|
Interesting, it works now and no error. Who knows why, this is all magic to me. |
When it will be fixed? I'm still facing the issue and i'm using camera plugin 0.2.3 version. |
It was never merged in... I'm not sure how to get a reviewer to look at it. |
@kroikie I saw you were assigned to some other pull requests. Perhaps you can take a look at this or tag somebody else who can? |
Hi @kmorkos Everything looks good except I think you should re-register the |
packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java
Outdated
Show resolved
Hide resolved
@bparrishMines thanks for checking this out. That makes sense, just made that change! |
Merged! I created a PR to bump the version on pub. |
@bparrishMines thanks! Can you push the update to pub please? 😄 |
@kmorkos Sorry about that! Published! |
…e camera (flutter#645)" This reverts commit 12b5f75.
Fix crash referenced in flutter/flutter#18348