Added iOS location plugin to showcase background execution APIs #656
Conversation
bkonyi
force-pushed
the
location_background_plugin
branch
from
2a49dba
to
54781cb
Compare
bkonyi
changed the title
|
|
||
| @Override | ||
| public void onMethodCall(MethodCall call, Result result) { | ||
| if (call.method.equals("getPlatformVersion")) { |
There was a problem hiding this comment.
Should this return result.notImplemented() unconditionally?
There was a problem hiding this comment.
Didn't even think to look at the Android stuff. Thanks!
| /// This is an example of a callback for LocationBackgroundPlugin's | ||
| /// `startMonitoringLocation`. A callback can be defined anywhere in an | ||
| /// application's code, but cannot be from another program. | ||
| class Foo { |
There was a problem hiding this comment.
Let's have a better name than Foo =) Something that hints at what one might do with location data. Maybe "LocationMonitor" or ...
There was a problem hiding this comment.
This was left over from testing, so I'll go with your suggestion :)
| // isolates since they do not share memory. | ||
| uiSendPort = IsolateNameServer.lookupPortByName(kLocationPluginPortName); | ||
| } | ||
| uiSendPort?.send(location.toJson()); |
There was a problem hiding this comment.
What happens when the foreground isolate closes the port?
There was a problem hiding this comment.
I've changed this so the port lookup is done on each event since there's really no other way to tell that an isolate port has been closed from the SendPort. Thoughts?
| } | ||
|
|
||
| // Listen on the port for location updates from our background callback. | ||
| _foregroundPort.listen((dynamic message) { |
There was a problem hiding this comment.
When does this port get closed?
There was a problem hiding this comment.
This port should stay open the life of the UI, but I've updated this logic to remove the port from the IsolateNameServer on close.
bkonyi
force-pushed
the
location_background_plugin
branch
from
5dd6c5d
to
358aa9d
Compare
bkonyi
force-pushed
the
location_background_plugin
branch
from
bc11f5c
to
60930dd
Compare
| # Flutter Background Execution Sample - LocationBackgroundPlugin | ||
|
|
||
| A example Flutter plugin that showcases background execution using iOS location services. | ||
|
|
There was a problem hiding this comment.
Not necessarily in this PR, but it would be good to fill this out with brief installation and usage examples.
|
|
||
| @Override | ||
| public void onMethodCall(MethodCall call, Result result) { | ||
| result.notImplemented(); |
There was a problem hiding this comment.
If you had plans to implement the Android side, you might add a TODO here that points to the API to use and explains the strategy a bit.
| flutter_test: | ||
| sdk: flutter | ||
|
|
||
| location_background_plugin: |
There was a problem hiding this comment.
Should this be a regular dependency?
There was a problem hiding this comment.
Probably. Not sure how that ended up there.
|
|
||
| #import <CoreLocation/CoreLocation.h> | ||
|
|
||
| @implementation LocationBackgroundPlugin { |
There was a problem hiding this comment.
As with the android_alarm_manager plugin, I think this file needs detailed comments so that 3p plugin developers know how to hook into the background execution features of the engine.
No description provided.