Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Manually Roll Flutter from 61e927d22fe6 to d2e6dfefa5ca (143 revisions) #6723

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

ditman
Copy link
Member

@ditman ditman commented Nov 19, 2022

In order to land this roll, I had to slow down a test that used to fling Link widgets up to a much slower pace than before.

This is probably a regression in the engine/framework bits and pieces and should be investigated here!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Nov 19, 2022
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this temporary fix!

@ditman
Copy link
Member Author

ditman commented Nov 19, 2022

A new issue for the label platform-web so this change can be assessed further (and hopefully reverted!), it might be a symptom of a perf regression.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 19, 2022
@ditman
Copy link
Member Author

ditman commented Nov 19, 2022

Created issue to investigate this, here: flutter/flutter#115679

@auto-submit auto-submit bot merged commit d6c0bcb into flutter:main Nov 19, 2022
@ditman ditman deleted the chill-link-widget-test-scroll branch November 19, 2022 01:42
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
…lutter#6723)

* Slow down link_widget_test scroll extent so test passes (framework/engine regression?)

* Manually Roll Flutter from 61e927d to d2e6dfe (143 revisions)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 21, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 21, 2022
* 017e776f9 Revert "[ci]Temporarily disable starqlteue on firebase device lab (#6657)" (flutter/plugins#6710)

* d6c0bcbf2 [ci] Manually Roll Flutter from 61e927d to d2e6dfe (143 revisions) (flutter/plugins#6723)

* 283122b1f Roll Flutter from d2e6dfe to 46d868c (5 revisions) (flutter/plugins#6724)

* 1aabcd62a [camera] Export VideoCaptureOptions so that implementers can use it (flutter/plugins#6666)

* 475caa001 Roll Flutter from 46d868c to 633d7ef (8 revisions) (flutter/plugins#6725)
@ditman ditman self-assigned this Dec 2, 2022
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…#115761)

* 017e776f9 Revert "[ci]Temporarily disable starqlteue on firebase device lab (flutter#6657)" (flutter/plugins#6710)

* d6c0bcbf2 [ci] Manually Roll Flutter from 61e927d to d2e6dfe (143 revisions) (flutter/plugins#6723)

* 283122b1f Roll Flutter from d2e6dfe to 46d868c (5 revisions) (flutter/plugins#6724)

* 1aabcd62a [camera] Export VideoCaptureOptions so that implementers can use it (flutter/plugins#6666)

* 475caa001 Roll Flutter from 46d868c to 633d7ef (8 revisions) (flutter/plugins#6725)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…#115761)

* 017e776f9 Revert "[ci]Temporarily disable starqlteue on firebase device lab (flutter#6657)" (flutter/plugins#6710)

* d6c0bcbf2 [ci] Manually Roll Flutter from 61e927d to d2e6dfe (143 revisions) (flutter/plugins#6723)

* 283122b1f Roll Flutter from d2e6dfe to 46d868c (5 revisions) (flutter/plugins#6724)

* 1aabcd62a [camera] Export VideoCaptureOptions so that implementers can use it (flutter/plugins#6666)

* 475caa001 Roll Flutter from 46d868c to 633d7ef (8 revisions) (flutter/plugins#6725)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
…lutter#6723)

* Slow down link_widget_test scroll extent so test passes (framework/engine regression?)

* Manually Roll Flutter from 61e927d to d2e6dfe (143 revisions)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: url_launcher platform-web
Projects
None yet
2 participants