This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Handle empty grantResults on permission request #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
approved these changes
Nov 28, 2022
Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
|
@camsim99 Unfortunately the Mac_x64 check keeps failing. There is nothing new to rebase on |
|
@davidmartos96 I re-ran it because I think it's a flaky test, unfortunately. It looks like it passed! |
Great! |
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 6, 2022
* 63f1b8fb6 [camera] Handle empty grantResults on permission request (flutter/plugins#6758) * 1579f2f33 Roll Flutter from 33f3e13 to 30fc993 (6 revisions) (flutter/plugins#6791) * 345bddbd8 [gh_actions]: Bump github/codeql-action from 2.1.27 to 2.1.35 (flutter/plugins#6788) * 374e59804 [camera] Add ability to concurrently record and stream video (flutter/plugins#6290)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…#116591) * 63f1b8fb6 [camera] Handle empty grantResults on permission request (flutter/plugins#6758) * 1579f2f33 Roll Flutter from 33f3e13 to 30fc993 (6 revisions) (flutter/plugins#6791) * 345bddbd8 [gh_actions]: Bump github/codeql-action from 2.1.27 to 2.1.35 (flutter/plugins#6788) * 374e59804 [camera] Add ability to concurrently record and stream video (flutter/plugins#6290)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#116591) * 63f1b8fb6 [camera] Handle empty grantResults on permission request (flutter/plugins#6758) * 1579f2f33 Roll Flutter from 33f3e13 to 30fc993 (6 revisions) (flutter/plugins#6791) * 345bddbd8 [gh_actions]: Bump github/codeql-action from 2.1.27 to 2.1.35 (flutter/plugins#6788) * 374e59804 [camera] Add ability to concurrently record and stream video (flutter/plugins#6290)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* [camera] Handle empty grantResults on permission request * update changelog and add test * fix typo * format * Update packages/camera/camera_android/CHANGELOG.md Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles a special situation where the grantResults array could be empty when asking for permissions.
Fixes flutter/flutter#116047
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.