This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Android and iOS BarcodeDetector options #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Jul 25, 2018
| "pronunciation", barcode.getContactInfo().getName().getPronunciation()); | ||
| name.put("suffix", barcode.getContactInfo().getName().getSuffix()); | ||
| Map<String, Object> name = new HashMap<>(); | ||
| if (barcode.getContactInfo().getName() != null) { |
There was a problem hiding this comment.
Maybe save barcode.getContactInfo().getName() in an instance variable to make the code below simpler?
There was a problem hiding this comment.
Might also be nice for the code below...
| @@ -1,7 +1,7 @@ | |||
| name: firebase_ml_vision | |||
| description: Flutter plugin for Google ML Vision for Firebase, an SDK that brings Google's machine | |||
| learning expertise to Android and iOS apps in a powerful yet easy-to-use package. | |||
| version: 0.0.2 | |||
| version: 0.0.3 | |||
There was a problem hiding this comment.
The change log says this is 0.1.0?
| ## 0.1.0 | ||
|
|
||
| * **Breaking Change** Add Barcode, Face, and Label on-device detectors. | ||
| * Remove close method. |
There was a problem hiding this comment.
Was that removed in a previous PR? Doesn't seem to be included in this one.
There was a problem hiding this comment.
Yea, I snuck in the version upgrade so you would only need to review 2 PRs not 3. :)
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.