New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview and video size with satisfying conditions of multiple outputs. #689

Merged
merged 3 commits into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@ryuta46
Contributor

ryuta46 commented Jul 28, 2018

In camera plugin, createCaptureSession is called for multiple outputs.

According to API reference of createCaptureSession, guarantee range of output resolution is decided depending on the level of camera device in case of multiple output.

API reference of createCaptureSession

Currently, preview size and video capture size is decided only depending on StreamConfigurationMap.getOutputSizes(int).
For this reason, the following error occurs on some devices and the camera device can not be used.

W/CameraDevice-JV-0(17996): Stream configuration failed due to: endConfigure:343: Camera 0: Unsupported set of inputs/outputs provided
E/CameraCaptureSession(17996): Session 0: Failed to create capture session; configuration failed

This PR fixes preview size and video capture size to solve the problem.

@googlebot

This comment has been minimized.

googlebot commented Jul 28, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Jul 28, 2018

@ryuta46

This comment has been minimized.

Contributor

ryuta46 commented Jul 28, 2018

I signed it!

@googlebot

This comment has been minimized.

googlebot commented Jul 28, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jul 28, 2018

@Hixie Hixie requested a review from bparrishMines Oct 30, 2018

@bparrishMines

Looks good! Thanks for the contribution!

@bparrishMines bparrishMines merged commit e29b8a8 into flutter:master Oct 31, 2018

6 of 8 checks passed

build-ipas PLUGIN_SHARDING:--shardIndex 0 --shardCount 2
Details
build-ipas PLUGIN_SHARDING:--shardIndex 1 --shardCount 2
Details
analyze
Details
build-apks+java-test PLUGIN_SHARDING:--shardIndex 0 --shardCount 2
Details
build-apks+java-test PLUGIN_SHARDING:--shardIndex 1 --shardCount 2
Details
cla/google All necessary CLAs are signed
publishable
Details
test+format
Details

bparrishMines added a commit to bparrishMines/plugins that referenced this pull request Oct 31, 2018

bparrishMines added a commit that referenced this pull request Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment