This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Fix preview and video size with satisfying conditions of multiple outputs. #689
Merged
bparrishMines
merged 3 commits into
flutter:master
from
ryuta46:fix_preview_and_video_size
Oct 31, 2018
Merged
Fix preview and video size with satisfying conditions of multiple outputs. #689
bparrishMines
merged 3 commits into
flutter:master
from
ryuta46:fix_preview_and_video_size
Oct 31, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
bparrishMines
approved these changes
Oct 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the contribution!
bparrishMines
added a commit
to bparrishMines/plugins
that referenced
this pull request
Oct 31, 2018
bparrishMines
added a commit
that referenced
this pull request
Oct 31, 2018
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…puts. (flutter#689) * fix preview size and video size to satisfy conditions for output to multiple targets.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit c59c5ef.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…iple outputs. (flutter#689)" This reverts commit 7f71c4b.
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
…puts. (flutter#689) * fix preview size and video size to satisfy conditions for output to multiple targets.
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In camera plugin,
createCaptureSession
is called for multiple outputs.According to API reference of createCaptureSession, guarantee range of output resolution is decided depending on the level of camera device in case of multiple output.
API reference of createCaptureSession
Currently, preview size and video capture size is decided only depending on StreamConfigurationMap.getOutputSizes(int).
For this reason, the following error occurs on some devices and the camera device can not be used.
This PR fixes preview size and video capture size to solve the problem.