This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
_dynamicLink variable was cleared after user get dynamicLink (iOS) #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bparrishMines , do you know who update the plugin from pub to get the latest changes? https://pub.dartlang.org/packages/firebase_dynamic_links |
|
@diegoveloper Yea I'm working on it now and created a PR that will update the version and some comments. I'll merge and publish once I get a review. |
|
@diegoveloper Thanks for catching this for us! |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a fix for this Issue #19820.
The issue only happens in iOS , when the user opens a dynamic link, and after redirecting to the application, the user obtains the link using this code:
The problem is when you call that method again, the expected result must be null since it was previously obtained.
To solve this, after obtaining and returning the link, the _dynamicLink variable is set to null.