[path_provider] Fix iOS getApplicationSupportDirectory regression
#7026
Conversation
When switching iOS to share the macOS implementation, the application support path for iOS accidentally changed because I forgot the macOS implementation added an extra subdirectory to it. This fixes that regression by returning iOS to the path `path_provider_ios` used. Fixes flutter/flutter#119133
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| /* Begin PBXBuildFile section */ | |||
| 1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */; }; | |||
| 3380327729784D96002D32AE /* RunnerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3380327629784D96002D32AE /* RunnerTests.swift */; }; | |||
| 33258D7929818305006BAA98 /* RunnerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 33258D7729818302006BAA98 /* RunnerTests.swift */; }; | |||
There was a problem hiding this comment.
My previous change still had a folder reference to RunnerTests/, but that folder doesn't exist any more so the Xcode UI was really confused. I re-created RunnerTests as a non-folder group, which is why there are changes in the project.
stuartmorgan
changed the title
getApplicationSupportDirectory regression
I'll teach cocoon about the new |
|
Actually, we should just name the directory RunnerTests, I'll fix that instead. |
…lutter#7026) When switching iOS to share the macOS implementation, the application support path for iOS accidentally changed because I forgot the macOS implementation added an extra subdirectory to it. This fixes that regression by returning iOS to the path `path_provider_ios` used. Fixes flutter/flutter#119133
* bc0174fd5 [path_provider] Fix iOS `getApplicationSupportDirectory` regression (flutter/plugins#7026) * 15d799b89 [url_launcher] Convert Windows to Pigeon (flutter/plugins#6991) * dc8ad7701 Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter/plugins#7025) * e9406bc20 [camerax] Adds functionality to bind UseCases to a lifecycle (flutter/plugins#6939)
When switching iOS to share the macOS implementation, the application support path for iOS accidentally changed because I forgot the macOS implementation added an extra subdirectory to it. This fixes that regression by returning iOS to the path
path_provider_iosused.This temporarily reverts the as-yet-unshipped bump of the minimum version to 3.0, so that 2.10 users aren't stuck with the previous version that had the regression (which I will retract once this is published). I'll re-bump to 3.0 as a follow-up.
Fixes flutter/flutter#119133
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).