This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add an initialUrl and a javaScriptMode parameters to WebView #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding just these 2 parameters to set up the skeleton for webview settings and initial parameters. Settings (like javaScriptMode) are set and updated by rebuilding the widget. initialUrl is a covinience parameter for simple use cases, as the WebView's loadUrl method cannot be modeled nicely as a widget parameter (e.g when the widget is rebuilt with the same url value there is no nice way to tell if you should load that url again or not). These kind of "edge triggers" fit in the WevView's controller. initialUrl is completely ignored when the widget is rebuilt.
amirh
force-pushed
the
webview_3_javascript
branch
from
111f480
to
cc390de
Compare
nichtverstehen
pushed a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 6, 2018
…r#753) Adding just these 2 parameters to set up the skeleton for webview settings and initial parameters. Settings (like javaScriptMode) are set and updated by rebuilding the widget. initialUrl is a covinience parameter for simple use cases, as the WebView's loadUrl method cannot be modeled nicely as a widget parameter (e.g when the widget is rebuilt with the same url value there is no nice way to tell if you should load that url again or not). These kind of "edge triggers" fit in the WevView's controller. initialUrl is completely ignored when the widget is rebuilt.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…r#753) Adding just these 2 parameters to set up the skeleton for webview settings and initial parameters. Settings (like javaScriptMode) are set and updated by rebuilding the widget. initialUrl is a covinience parameter for simple use cases, as the WebView's loadUrl method cannot be modeled nicely as a widget parameter (e.g when the widget is rebuilt with the same url value there is no nice way to tell if you should load that url again or not). These kind of "edge triggers" fit in the WevView's controller. initialUrl is completely ignored when the widget is rebuilt.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…flutter#753)" This reverts commit a259701.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding just these 2 parameters to set up the skeleton for webview
settings and initial parameters.
Settings (like javaScriptMode) are set and updated by rebuilding the
widget.
initialUrl is a covinience parameter for simple use cases, as the
WebView's loadUrl method cannot be modeled nicely as a widget parameter
(e.g when the widget is rebuilt with the same url value there is no nice
way to tell if you should load that url again or not).
These kind of "edge triggers" fit in the WevView's controller.
initialUrl is completely ignored when the widget is rebuilt.