This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Removed Google Guava dependency from firebase_auth. #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @kroikie |
|
LGTM |
|
Thanks @dnfield |
nichtverstehen
pushed a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 6, 2018
* Removed Google Guava dependency. * Fix formatting. * Fixed more formatted.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
* Removed Google Guava dependency. * Fix formatting. * Fixed more formatted.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
)" This reverts commit 0199f60.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Removed Google Guava dependency. * Fix formatting. * Fixed more formatted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REASON FOR CHANGE
Flutter apps that include the
firebase_authplugin would easily reach the 64K dex limit because of the addition of Guava. The guava library was adding considerable compilation time and size to the final APK. Expectations of new Flutter developers to grasp that they need to add Multi-dex and then Proguard to fix this issue is really silly.CHANGE MADE
Replaced usages of guava's:
ImmutableListandImmutableMapwith platformCollections.unmodifiableList()andCollections.unmodifiableMap().This simple change makes a huge difference.