This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add biometry type detection to local_auth plugin #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
mehmetf
suggested changes
Oct 12, 2018
packages/local_auth/android/src/main/java/io/flutter/plugins/localauth/LocalAuthPlugin.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 13, 2018 13:01
…ableBiometrics + enums)
|
I signed it! |
|
CLAs look good, thanks! |
mehmetf
reviewed
Oct 13, 2018
packages/local_auth/android/src/main/java/io/flutter/plugins/localauth/LocalAuthPlugin.java
Outdated
Show resolved
Hide resolved
mehmetf
approved these changes
Oct 14, 2018
|
Thank you! This looks good now. One last thing: Please update changelog.md and pubspec.yaml with a new version: |
mehmetf
reviewed
Oct 14, 2018
|
this is going to be great, When can we expect this to get this version of plugin in pub? |
|
Done! |
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
Now the users can determine two things: - Whether the phone is capable of biometrics. - Whether any biometric checks are available to the app.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 3dbd333.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve Issue flutter/flutter#22727
Two new functions were added to the local_auth plugin
bool canCheckBiometrics> if device is able to do local auth (with biometrics)List<BiometricType> getAvailableBiometrics> list of enrolled biometricsEnum BiometricType:
@mehmetf here's the fix according to your mail. Thanks!