This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Change google-services.json and GoogleService-Info.plist of example #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetf
reviewed
Oct 17, 2018
kroikie
reviewed
Oct 17, 2018
|
Does firebase_auth need to be changed to follow suit? It depends on this plugin. |
|
This is mainly a change to the example, the plugin itself should not be affected. We may want to do a similar change to the firebase_auth example plugin if we have issues with the Firebase project that example uses. |
ened
reviewed
Oct 18, 2018
| @@ -5,7 +5,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:3.1.2' | |||
| classpath 'com.android.tools.build:gradle:3.2.0' | |||
There was a problem hiding this comment.
Suggested change
| classpath 'com.android.tools.build:gradle:3.2.0' | |
| classpath 'com.android.tools.build:gradle:3.2.1' |
There was a problem hiding this comment.
The rest of the plugins are at 3.2.0 and we try to keep them at the same version. So I think 3.2.0 will be the version until we update them all again. Same for the suggestion below.
| @@ -8,7 +8,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:3.1.2' | |||
| classpath 'com.android.tools.build:gradle:3.2.0' | |||
There was a problem hiding this comment.
Suggested change
| classpath 'com.android.tools.build:gradle:3.2.0' | |
| classpath 'com.android.tools.build:gradle:3.2.1' |
|
Any blockers for this? |
|
@mehmetf Yes, I'm trying to update the iOS plist too, but I'm running into errors. |
bparrishMines
changed the title
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…xample (flutter#859)" This reverts commit cb73f13.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.