This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempt to use a Detector multiple times on Android without calling
detector.close()
eventually the app will crash. This happens because a new detector is instantiated for eachdetectInImage
is called. I'm assuming the crash is from running out of memory (I get a seg fault error) because each detector loads a hefty model.iOS version doesn't have a close method, so I'm assuming it handles it's models differently.
My solution for this problem keeps one instance in memory to reuse. However, if the user wants to create a detector with different options, I close the previous instance and instantiate a new detector.
The other option would be to give each instantiated detector a handle, but closing and instantiating a new one doesn't take very long if there is a use case where multiple detectors are needed.