Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update docs/example for AdMob #880

Merged
merged 15 commits into from
Nov 10, 2018
Merged

Update docs/example for AdMob #880

merged 15 commits into from
Nov 10, 2018

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Nov 2, 2018

  1. Gradle 4.4 is no longer supported. We recently had another effort to upgrade the Gradle wrapper, looks like this repo was missed
  2. Instructions for avoiding admob plugin causes Android to crash on startup flutter#23659 and update the example project to work (it crashed as-is on Android).
  3. Deprecate the Dart counterparts that have been deprecated in Java/Objective C API.

Unfortunately, users will get scary red deprecation notices when they use this plugin until we remove the deprecated API completely - but it doesn't feel right to completely remove it until the underlying libraries do. That said, I'm open to suggestions.

@dnfield dnfield requested a review from kroikie November 2, 2018 16:08
@dnfield
Copy link
Contributor Author

dnfield commented Nov 2, 2018

We should republish the previous version of the firebase_admob plugin as 0.6.1+2 or possibly 0.6.2. The error this causes for users only fires at runtime and is a complete app crasher.

@dnfield dnfield changed the title update graddle-wrapper for all, update docs/example for AdMob Update docs/example for AdMob Nov 2, 2018
@kroikie kroikie self-assigned this Nov 8, 2018
@kroikie kroikie merged commit 4819d5b into flutter:master Nov 10, 2018
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
* Update docs/example for AdMob

* Deprecate dart methods
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Update docs/example for AdMob

* Deprecate dart methods
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants