[google_maps_flutter]Added support for drawing polylines to the google_maps flutter plugin…

[irevans]

This includes the flutter layer, android code and example application, but not iOS.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[irevans]

I would like to run the flutter_plugin_tools. From the google_maps_flutter directory I have ran:

flutter packages pub global activate flutter_plugin_tools

This appears to have worked. I then ran:

flutter packages pub global run flutter_plugin_tools format --plugins google_maps_flutter

However this fails with an error message: Error: Cannot find a "packages" sub-directory.

I realise this may be a novice question but I would appreciate some advice on how to overcome the above problem.

[amirh]

You should run it from the root folder of the plugins directory.

…

On Wed, Nov 28, 2018 at 7:01 AM irevans ***@***.***> wrote: I would like to run the flutter_plugin_tools. From the google_maps_flutter directory I have ran: flutter packages pub global activate flutter_plugin_tools This appears to have worked. I then ran: flutter packages pub global run flutter_plugin_tools format --plugins google_maps_flutter However this fails with an error message: Error: Cannot find a "packages" sub-directory. I realise this may be a novice question but I would appreciate some advice on how to overcome the above problem. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#941 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-gdZ03vnNV6owDKacKXKN-sH_jv7D5ks5uzqUxgaJpZM4Y3XRe> .

[irevans]

Hi Amir,

When I run the command from the plugins directory it fails with the following error:

Error: No pubspec.yaml file found. This command should be run from the root of your Flutter project. Do not run this command from the root of your git clone of Flutter.

You should run it from the root folder of the plugins directory.
…
On Wed, Nov 28, 2018 at 7:01 AM irevans @.***> wrote: I would like to run the flutter_plugin_tools. From the google_maps_flutter directory I have ran: flutter packages pub global activate flutter_plugin_tools This appears to have worked. I then ran: flutter packages pub global run flutter_plugin_tools format --plugins google_maps_flutter However this fails with an error message: Error: Cannot find a "packages" sub-directory. I realise this may be a novice question but I would appreciate some advice on how to overcome the above problem. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#941 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-gdZ03vnNV6owDKacKXKN-sH_jv7D5ks5uzqUxgaJpZM4Y3XRe .

[amirh]

Ohh just noticed you are running: flutter packages pub run it should be pub run.

[irevans]

Thanks Amir.

When you review these code changes I would be particularly interested in whether you think using null to represent the default pattern in the PolylineOptions class is a good idea. Perhaps using an empty list would be better, such that null is used to consistently mean "do not change this configuration option".

[amirh]

Can you make the googlebot happy ?

[irevans]

Hi Amir, I'm just waiting on my employer to confirm that they waive any rights to IP before signing the cla. Merely a formality that won't take long. Sorry for the delay.

[irevans]

I signed it!

[kunit1]

@irevans looks like bot is still not happy about cla.

Would be nice to have this merged (after it's been reviewed)

[irevans]

@kunit1 I'm waiting for my employer's "authorized signer" to complete the CLA signing process. It should be done soon.

I'm not sure what the following checks are failing, is this likely to be a consequence of the cla issue?

build-apks+java-test PLUGIN_SHARDING:--shardIndex 0 --shardCount 2
build-apks+java-test PLUGIN_SHARDING:--shardIndex 1 --shardCount 2

[joaquinperaza]

Great! I am looking to start coding polygon support, is nobody on that?

[irevans]

@joaquinpereaza only polyline support in this pull request (not polygon).

[ZatacaSystems]

@irevans hey! any news on the conflicts? I'm looking forward for this!

[irevans]

I signed it!

[irevans]

@amirh Hi Amir, the cla has been signed, any idea why that didn't trigger a rebuild of the project?

[irevans]

@amirh Hi Amir, are you able to shed some light on why the google bot claims the cla is not signed when I have supplied the information requested (when contributing on behalf of an employer) and it's been signed by the authorised signer?

I don't see any information from the build that would help me diagnose the problem, am I missing anything?

[googlebot]

CLAs look good, thanks!

[bright2kwame]

how do I add this pull request to my flutter project ??

[irevans]

@bright2kwame I would suggest you use pull request #1049 instead, since it has added iOS support on top of the android support in this pull request. You can use that by adding the following to your pubspec.yaml:

google_maps_flutter:
    git:
      url: git://github.com/awazgyawali/plugins/
      path: packages/google_maps_flutter
      ref: google_maps_polyline

[mendoza02]

I will do the same, Google is taking too much time to merge this pull request to the master. I definitely need polylines. Thanks guys

…

On Wed, Jan 30, 2019 at 3:40 PM irevans ***@***.***> wrote: @bright2kwame <https://github.com/bright2kwame> I would suggest you use pull request #1049 <#1049> instead, since it has added iOS support on top of the android support in this pull request. You can use that by adding the following to your pubspec.yaml: google_maps_flutter: git: url: git://github.com/awazgyawali/plugins/ path: packages/google_maps_flutter ref: google_maps_polyline — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#941 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALD991YXC3ePqJhPO3yc5o_4Ed1y1y_Nks5vIhEzgaJpZM4Y3XRe> .

[joaquinperaza]

Me too, also would try to add the pr of polygons, I am needing to continue working Joaquin Peraza Cel: 099 355553 e-mail: joaquin@peraza.uy El 30 ene. 2019, a la(s) 18:45, mendoza02 <notifications@github.com> escribió:

…

I will do the same, Google is taking too much time to merge this pull request to the master. I definitely need polylines. Thanks guys On Wed, Jan 30, 2019 at 3:40 PM irevans ***@***.***> wrote: > @bright2kwame <https://github.com/bright2kwame> I would suggest you use > pull request #1049 <#1049> > instead, since it has added iOS support on top of the android support in > this pull request. You can use that by adding the following to your > pubspec.yaml: > > google_maps_flutter: > git: > url: git://github.com/awazgyawali/plugins/ > path: packages/google_maps_flutter > ref: google_maps_polyline > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#941 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ALD991YXC3ePqJhPO3yc5o_4Ed1y1y_Nks5vIhEzgaJpZM4Y3XRe> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[irevans]

FYI. A fork of this pull request (#1049) has now been approved and merged.

[irevans]

FYI. A fork of this pull request (#1049) has now been approved and merged.