This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Keep a reference to the plugin registrar in FLTGoogleMapController.
#943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_registrar` field was never set in `FLTGoogleMapController`. This made asset lookup return nil in `interepretMapOptions` resulting in custom marker images not working.
| @@ -1,3 +1,6 @@ | |||
| ## 0.0.3+1 | |||
There was a problem hiding this comment.
nit: space after version and after changelog notes
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…flutter#943) The `_registrar` field was never set in `FLTGoogleMapController`. This made asset lookup return nil in `interepretMapOptions` resulting in custom marker images not working.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…roller`. (flutter#943)" This reverts commit 9b2e891.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_registrarfield was never set inFLTGoogleMapController.This made asset lookup return nil in
interepretMapOptionsresulting incustom marker images not working.