Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visual sample index] Improve cookbook screenshots #394

Open
johnpryan opened this issue Mar 23, 2020 · 6 comments
Open

[visual sample index] Improve cookbook screenshots #394

johnpryan opened this issue Mar 23, 2020 · 6 comments

Comments

@johnpryan
Copy link
Contributor

johnpryan commented Mar 23, 2020

Cookbook screenshots should include a screenshot of the running app, most likely the DartPad iframe on the page.

Cookbook scraper instructions

Cookbook scraper source code

@johnpryan johnpryan added the p1 label Mar 23, 2020
@johnpryan johnpryan changed the title [visual samples index] Improve cookbook screenshots [visual sample index] Improve cookbook screenshots Mar 25, 2020
@mohak852
Copy link
Contributor

I wanna work on this issue. @RedBrogdon @johnpryan

@johnpryan
Copy link
Contributor Author

@mohak852 I added some links to the relevant code and README - let me know if you have any questions.

@mohak852
Copy link
Contributor

@johnpryan Should I begin with one cookbook tutorial and then proceed for the other or should I add all together in one single go?

@johnpryan
Copy link
Contributor Author

The scraper needs to be modified to inspect the DartPad iframe. Once it's modified it will update all the screenshots.

@tusharojha
Copy link
Contributor

Hi @johnpryan
I am interested to solve this issue but since it's my first try with this project. I think this line https://github.com/flutter/samples/blob/master/web/samples_index/lib/cookbook.dart#L57 takes the screenshot which later gets saved but how am I supposed to inspect the DartPad iframe.

I tried to read more on this over the internet but didn't find many resources, but a workaround is to crop the screenshot but that's also not the case here. It would be great if you can suggest to me the right path to follow.

@johnpryan
Copy link
Contributor Author

I haven't looked into it, but the idea is to load page declared in the src attribute of the iframe and then take a screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants